Skip to content

Conversation

@kjy5
Copy link
Member

@kjy5 kjy5 commented Apr 17, 2025

No description provided.

@kjy5 kjy5 requested a review from Copilot April 17, 2025 07:58
@kjy5 kjy5 linked an issue Apr 17, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • Assets/Prefabs/UI/SettingsMenu/Menus/EphysLinkMenu.prefab: Language not supported
  • Packages/manifest.json: Language not supported
  • Packages/packages-lock.json: Language not supported
  • ProjectSettings/ProjectSettings.asset: Language not supported
Comments suppressed due to low confidence (3)

Assets/Scripts/Pinpoint/UI/EphysLinkSettings/EphysLinkSettings.cs:119

  • The condition for activating the pathfinder port input field changed from 'type == 2' to 'type == 1'. Please verify that this update correctly reflects the intended mapping of manipulator types.
_pathfinderPortInputField.gameObject.SetActive(type == 1);

Assets/Scripts/Pinpoint/UI/EphysLinkSettings/EphysLinkSettings.cs:228

  • The simplified mapping for manipulator type string now only distinguishes between a value of 0 and non-0, removing previous cases like 'ump-3', 'new-scale', and 'ump-4'. Confirm that this change meets the intended functionality.
var manipulatorTypeString = _manipulatorTypeDropdown.value == 0 ? "ump" : "pathfinder-mpm";

Assets/Scripts/EphysLink/CommunicationManager.cs:25

  • The minimum version constant has been updated from 2.0.0 to 2.1.0. Ensure that this change is consistent with version requirements across the codebase.
private static readonly int[] EPHYS_LINK_MIN_VERSION = { 2, 1, 0 };

@kjy5 kjy5 merged commit 08508fb into develop Apr 17, 2025
@kjy5 kjy5 deleted the 775-re-add-ump-3 branch April 17, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-add uMp-3

1 participant