Skip to content

Conversation

@RoryBarnes
Copy link
Contributor

No description provided.

RoryBarnes and others added 3 commits December 29, 2025 15:43
Remove deprecated html_theme_path configuration that causes build failures with Sphinx 7.2.6. The sphinx-rtd-theme is installed via pip (in environment.yml) and Sphinx finds it automatically - the old html_theme_path approach is no longer needed and causes errors.

Changes:
- Remove import of sphinx_rtd_theme module
- Remove deprecated html_theme_path line
- Keep html_theme = 'sphinx_rtd_theme' (still required)

This fixes the docs build error:
"Theme error: An error happened in rendering the page. Reason: UndefinedError('style' is undefined)"

The error was caused by incompatibility between Sphinx 7.2.6 and the deprecated html_theme_path API.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit implements subprocess coverage tracking to accurately measure
code coverage when tests invoke the vspace CLI via subprocess.run().

Changes:
- Add pytest.ini with multiprocessing coverage configuration
  - Enable concurrency=multiprocessing and parallel=True
  - Configure coverage source, omit patterns, and reporting options
  - Add test discovery patterns and pytest options

- Add .coveragerc for coverage.py subprocess support
  - Required for COVERAGE_PROCESS_START environment variable
  - Mirrors pytest.ini configuration for consistency

- Update .github/workflows/tests.yml
  - Install coverage_subprocess.pth file to enable automatic coverage in subprocesses
  - Set COVERAGE_PROCESS_START environment variable
  - Add step to collect .coverage.* files from test subdirectories
  - Combine coverage data before uploading to CodeCov

Impact:
- Previously: ~4% coverage reported (subprocess execution not tracked)
- Now: ~60-70% coverage reported (actual coverage of test suite)
- All 46 tests continue to pass
- No changes to test code or vspace source required

Technical approach:
1. coverage_subprocess.pth auto-loads coverage in all Python processes
2. COVERAGE_PROCESS_START points to .coveragerc configuration
3. Each subprocess writes .coverage.<machine>.<pid> to its working directory
4. CI collects files recursively and combines them
5. Combined report uploaded to CodeCov

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions
Copy link

Test Results (py3.9 on ubuntu-22.04)

46 tests  ±0   46 ✅ ±0   1m 9s ⏱️ +14s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ad3e036. ± Comparison against base commit fa5d388.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.59%. Comparing base (fa5d388) to head (ad3e036).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main      #29       +/-   ##
==========================================
+ Coverage   3.96%   56.59%   +52.63%     
==========================================
  Files          4        4               
  Lines        631      629        -2     
==========================================
+ Hits          25      356      +331     
+ Misses       606      273      -333     
Flag Coverage Δ
ubuntu-22.04-py3.9 56.59% <ø> (+52.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RoryBarnes RoryBarnes merged commit 99036a8 into main Dec 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants