Skip to content

Fix/set domain of field #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 4 commits into from
Mar 26, 2025
Merged

Fix/set domain of field #3842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dab3923
fix: data.fields can set domain of field
xile611 Mar 25, 2025
e87b885
docs: update changlog of rush
xile611 Mar 25, 2025
adc0cc4
feat: add options `full` to lockStatisticsByDomain
xile611 Mar 26, 2025
9216765
docs: update changlog of rush
xile611 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-set-domain-of-field_2025-03-25-07-57.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: data.fields can set domain of field\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-set-domain-of-field_2025-03-26-02-12.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "feat: add options `full` to lockStatisticsByDomain\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
2 changes: 1 addition & 1 deletion packages/vchart/src/data/transforms/dimension-statistics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export const dimensionStatisticsOfSimpleData = (
if (f.customize) {
result[key][op] = f.customize;
} else {
if (dataFieldInKey && dataFieldInKey.lockStatisticsByDomain && !isNil(dataFieldInKey.domain)) {
if (dataFieldInKey && dataFieldInKey.lockStatisticsByDomain === true && !isNil(dataFieldInKey.domain)) {
if (op === 'values') {
result[key][op] = dataFieldInKey.domain.slice();
return;
Expand Down
12 changes: 9 additions & 3 deletions packages/vchart/src/typings/spec/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,18 @@ export type BuildInTransformOptions =
export interface IFieldsMeta {
/** TODO: 字段通用format, 暂时先不支持 */
// format?: (datum: Datum, index: number) => unknown;
/** 字段别名 */
/**
* 字段别名
*/
alias?: string;
/** 字段取值范围 */
domain?: StringOrNumber[];
/** 是否使用 domain 锁定统计信息。默认为 false */
lockStatisticsByDomain?: boolean;
/**
* 是否使用 domain 锁定统计信息。默认为 false
* true - 在图例交互场景，也固定domain
* 当设置为 `onlyFull` 时，仅在初始化的展示完整数据的场景锁定domain，在交互触发的筛选场景不锁定
*/
lockStatisticsByDomain?: boolean | 'onlyFull';
/** 连续型 还是 离散型 */
type?: 'ordinal' | 'linear';
/** 排序顺序 不设置的话当前维度不进行排序 */
Expand Down