Skip to content

Fix/react vchart children #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 2 commits into from
Mar 27, 2025
Merged

Fix/react vchart children #3852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca963df
fix: children of tooltip should not be set to spec
xile611 Mar 27, 2025
2a25c83
docs: update changelog of rush
xile611 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vchart/fix-react-vchart-children_2025-03-27-02-02.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vchart",
"comment": "fix(react-vchart): children of tooltip should not be set to spec",
"type": "none"
}
],
"packageName": "@visactor/vchart"
}
2 changes: 1 addition & 1 deletion packages/react-vchart/src/charts/BaseChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ const BaseChart: React.FC<Props> = React.forwardRef((props, ref) => {

if (
!isEqual(newSpec, prevSpec.current, { skipFunction: skipFunctionDiff }) ||
!isEqual(newSpecFromChildren, specFromChildren.current)
!isEqual(newSpecFromChildren, specFromChildren.current, { skipFunction: skipFunctionDiff })
) {
prevSpec.current = newSpec;
specFromChildren.current = newSpecFromChildren;
Expand Down
3 changes: 2 additions & 1 deletion packages/react-vchart/src/components/BaseComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export const createComponent = <T extends ComponentProps>(
VChart.useRegisters(registers);
}

const ignoreKeys = ['updateId', 'componentId'];
// tooltip component 不支持 children，其他组件暂时也都不支持
const ignoreKeys = ['updateId', 'componentId', 'children'];
const notSpecKeys = supportedEvents ? Object.keys(supportedEvents).concat(ignoreKeys) : ignoreKeys;

const Comp: React.FC<T> = (props: T) => {
Expand Down