Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vchart",
"comment": "fix: clear event listener for normal animation when updateSpec, #3881",
"type": "none"
}
],
"packageName": "@visactor/vchart"
}
4 changes: 4 additions & 0 deletions packages/vchart/src/compile/mark/compilable-mark.ts
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,10 @@ export abstract class CompilableMark extends GrammarItem implements ICompilableM
return undefined;
}

clear() {
this._event.off(VGRAMMAR_HOOK_EVENT.AFTER_DO_RENDER);
}

release() {
super.release();
this.state.release();
Expand Down
4 changes: 4 additions & 0 deletions packages/vchart/src/model/base-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ export abstract class BaseModel<T extends IModelSpec> extends CompilableBase imp
// do nothing
}

clear() {
this.getMarks().forEach(m => m.clear?.());
}

release() {
this._releaseEvent();
this._spec = undefined;
Expand Down
Loading