Skip to content

Fix/crosshari default select axis index #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 2 commits into from
Apr 17, 2025
Merged

Fix/crosshari default select axis index #3904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd054c
fix: when set defaultSelect of crosshair, `axisIndex` should have a d…
xile611 Apr 9, 2025
198f843
docs: update changlog of rush
xile611 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-crosshari-defaultSelect-axisIndex_2025-04-09-07-30.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: when set defaultSelect of crosshair, `axisIndex` should have a default value: 0\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
2 changes: 1 addition & 1 deletion packages/vchart/src/component/crosshair/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export abstract class BaseCrossHair<T extends ICartesianCrosshairSpec | IPolarCr
const fieldSpec = (this._spec as any)[field];

if (fieldSpec && fieldSpec.visible && fieldSpec.defaultSelect) {
const { axisIndex, datum } = fieldSpec.defaultSelect;
const { axisIndex = 0, datum } = fieldSpec.defaultSelect;
const axis = this._option.getComponentsByKey('axes').find(c => c.getSpecIndex() === axisIndex) as IAxis;

if (axis) {
Expand Down
Loading