Skip to content

Fix/dom tooltip title order #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 2 commits into from
May 28, 2025
Merged

Fix/dom tooltip title order #3998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25b7eb
fix: fix the order of title in mark tooltip when dimension tooltip ha…
xile611 May 28, 2025
b00447e
docs: update changlog of rush
xile611 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-dom-tooltip-title-order_2025-05-28-03-46.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: fix the order of title in mark tooltip when dimension tooltip has no title, fix #3991\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
10 changes: 8 additions & 2 deletions packages/vchart/src/plugin/components/tooltip-handler/dom-tooltip-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,21 @@ export class DomTooltipHandler extends BaseTooltipHandler {
const rowStyle = this._domStyle.row;
const chilren = [...(this._rootDom.children as any)] as HTMLElement[];
let titleDom = chilren.find(child => child.className.includes(TOOLTIP_TITLE_CLASS_NAME));
let contentDom = chilren.find(child => child.className.includes(TOOLTIP_CONTENT_BOX_CLASS_NAME));

if (!titleDom && title.visible !== false) {
titleDom = document.createElement('h2');
const span = document.createElement('span');
titleDom.appendChild(span);

titleDom.classList.add(TOOLTIP_TITLE_CLASS_NAME);
this._rootDom.appendChild(titleDom);

// 将 titleDom 插入到 this._rootDom 中作为第一个节点
if (this._rootDom.firstChild) {
this._rootDom.insertBefore(titleDom, this._rootDom.firstChild);
} else {
this._rootDom.appendChild(titleDom);
}
}

if (titleDom && title.visible !== false) {
Expand All @@ -223,7 +230,6 @@ export class DomTooltipHandler extends BaseTooltipHandler {
titleDom.parentNode.removeChild(titleDom);
}

let contentDom = chilren.find(child => child.className.includes(TOOLTIP_CONTENT_BOX_CLASS_NAME));
const columns = ['shape', 'key', 'value'];

if (!contentDom && hasContent) {
Expand Down
Loading