Skip to content

fix: call setenv when create vchart #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 2 commits into from
Jun 17, 2025
Merged

fix: call setenv when create vchart #4037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29bc2b1
fix: call setenv when create vchart
neuqzxy Jun 17, 2025
6f50bf3
feat: add rush change file
neuqzxy Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vchart/fix-setenv_2025-06-17-07-07.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vchart",
"comment": "fix: fix issue with feishu block and call setenv when create vchart",
"type": "none"
}
],
"packageName": "@visactor/vchart"
}
16 changes: 13 additions & 3 deletions packages/vchart/src/compile/compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { type IGraphicContext, type IMark, type IMarkGraphic } from '../mark/int
import { Factory } from '../core/factory';
import type { Gesture } from '@visactor/vrender-kits';
import { findMarkGraphic, getDatumOfGraphic } from '../util/mark';
import { diffMarks, findSimpleMarks, traverseGroupMark } from './util';
import { diffMarks, findSimpleMarks, toRenderMode, traverseGroupMark } from './util';
import { log } from '../util/debug';

type EventListener = {
Expand Down Expand Up @@ -107,8 +107,18 @@ export class Compiler implements ICompiler {
return;
}

const { autoRefreshDpr, dpr, mode, gestureConfig, interactive, clickInterval, autoPreventDefault, background } =
this._option;
const {
autoRefreshDpr,
dpr,
mode,
modeParams,
gestureConfig,
interactive,
clickInterval,
autoPreventDefault,
background
} = this._option;
vglobal.setEnv(toRenderMode(mode), modeParams ?? {});
this._stage =
this._option.stage ??
(new Stage({
Expand Down
Loading