Skip to content

Fix/multi layer performance #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 2 commits into from
Jun 26, 2025
Merged

Fix/multi layer performance #4058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
740f9a9
fix: only calculate multi layer label items when need, fix #4056
xile611 Jun 25, 2025
9e875eb
docs: update changlog of rush
xile611 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-multi-layer-performance_2025-06-25-09-04.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: only calculate multi layer label items when need, fix #4056\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
3 changes: 2 additions & 1 deletion packages/vchart/src/component/axis/mixin/band-axis-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ export class BandAxisMixin {
const labelItems: Dict<any>[][] = [];
let preData: any[] = [];

this._scales.forEach((scale, index) => {
// 只有需要展示多层标签的时候，才需要计算，否则不需要计算
(this._spec.showAllGroupLayers ? this._scales : [this._scales[0]]).forEach((scale, index) => {
const tickData = this._tickDataMap[index];

// 因为多层级标签会依赖上一层标签的分组值定位，所以如果上一层标签没有内容，那么就直接获取 bandScale 的 domain()
Expand Down
Loading