Skip to content

Fix/fix type error of react vchart #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuefei1313 merged 2 commits into from
Sep 10, 2025
Merged

Fix/fix type error of react vchart #4188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb80a42
fix: fix the issue of className miss in react-vchart
xuefei1313 Sep 9, 2025
8b45a2c
docs: update changlog of rush
xuefei1313 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-fix-type-error-of-react-vchart_2025-09-09-08-55.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: fix the issue of className miss in react-vchart\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "lixuef1313@163.com"
}
3 changes: 2 additions & 1 deletion packages/react-vchart/src/charts/BaseChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ export interface BaseChartProps
DimensionEventProps,
HierarchyEventProps,
ChartLifeCycleEventProps,
IReactTooltipProps {
IReactTooltipProps,
ContainerProps {
vchartConstructor?: IVChartConstructor;
/** @deprecated 请使用 vchartConstructor */
vchartConstrouctor?: IVChartConstructor;
Expand Down
5 changes: 3 additions & 2 deletions packages/react-vchart/src/containers/withContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import type { StringOrNumber } from '@visactor/vchart';
import React, { useRef, useState, useLayoutEffect } from 'react';

export interface ContainerProps {
style?: React.CSSProperties;
className?: string;
width?: number | string;
height?: number | string;
id?: string;
id?: StringOrNumber;
}

export default function withContainer<P extends ContainerProps>(
Expand All @@ -25,7 +26,7 @@ export default function withContainer<P extends ContainerProps>(
return (
<div
ref={container}
id={id}
id={id?.toString()}
className={className}
style={{
position: 'relative',
Expand Down
Loading