Skip to content

fix: bad case of traverse aniamtion config #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuefei1313 merged 1 commit into from
Sep 18, 2025
Merged

fix: bad case of traverse aniamtion config #4194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/vchart/src/animation/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,8 @@ function produceOneByOne(
const userDelayAfter = isFunction(delayAfter)
? delayAfter(datum, g, params)
: isValidNumber(delayAfter)
? delayAfter
: 0;
? delayAfter
: 0;
let oneByOneTime = isFunction(oneByOne) ? oneByOne(datum, g, params) : oneByOne;
if (oneByOneTime === false) {
return userDelayAfter;
Expand Down Expand Up @@ -260,7 +260,8 @@ function traverseSpec(spec: any, transform: (node: any, key: string | number) =>
spec[index] = transform(spec[index], index);
traverseSpec(spec[index], transform, excludeKeys);
});
} else if (isObject(spec)) {
} else if (isObject(spec) && typeof spec !== 'function') {
// spec如果是函数, 无需遍历; 一个bad case: 线上环境在function的prototype上挂载了某个属性导致这里遍历的时候出现了死循环
for (const key in spec) {
if (!excludeKeys.includes(key)) {
spec[key] = transform(spec[key], key);
Expand Down
Loading