Skip to content

fix: add protect code of tooltip handler #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuefei1313 merged 3 commits into from
Jan 21, 2026
Merged

fix: add protect code of tooltip handler #4424

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
930345d
fix: add protect code of tooltip handler
skie1997 Jan 21, 2026
1fdb2eb
fix: format problem
skie1997 Jan 21, 2026
60afa3d
fix: format problem
skie1997 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/vchart/src/component/tooltip/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export class Tooltip extends BaseComponent<any> implements ITooltip {
return;
}

const container = this.tooltipHandler.getRootDom?.();
const container = this.tooltipHandler?.getRootDom?.();

if (container) {
container.addEventListener('pointerenter', () => {
Expand Down Expand Up @@ -608,7 +608,8 @@ export class Tooltip extends BaseComponent<any> implements ITooltip {

// 隐藏 tooltip
const handler = this._spec.handler ?? this.tooltipHandler;
if (handler.hideTooltip) {
// 防止用户自定义 handler 时，未实现 hideTooltip 方法
if (handler?.hideTooltip) {
const result = handler.hideTooltip.call(handler, params);
if (!result) {
this._isTooltipShown = false;
Expand All @@ -630,7 +631,7 @@ export class Tooltip extends BaseComponent<any> implements ITooltip {
}
this._enterable = newEnterable;

this.tooltipHandler.reInit?.();
this.tooltipHandler?.reInit?.();
} else {
this._initHandler();
}
Expand Down
Loading