Skip to content

Fix/fix bug of animation custom params #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 2 commits into from
Oct 31, 2025
Merged

Fix/fix bug of animation custom params #1965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4cf992
fix: fix the issue of custom animation params
xuefei1313 Oct 31, 2025
6b4be8b
docs: update changlog of rush
xuefei1313 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...es/@visactor/vrender-animate/fix-fix-bug-of-animation-custom-params_2025-10-31-08-53.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: fix the issue of custom animation params\n\n",
"type": "none",
"packageName": "@visactor/vrender-animate"
}
],
"packageName": "@visactor/vrender-animate",
"email": "lixuef1313@163.com"
}
10 changes: 8 additions & 2 deletions packages/vrender-animate/src/executor/animate-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,12 +424,18 @@ export class AnimateExecutor implements IAnimateExecutor {
) {
// 处理自定义动画
if (custom && customType) {
const customParams = {
const _customParameters = this.resolveValue(customParameters, graphic);
let customParams = _customParameters;
if (typeof customParams !== 'function') {
customParams = customParams(graphic.context?.data?.[0], graphic, {});
}
customParams = {
width: graphic.stage?.width || 0,
height: graphic.stage?.height || 0,
group: this._target.parent,
...this.resolveValue(customParameters, graphic)
..._customParameters
};

const objOptions = isFunction(options)
? options.call(
null,
Expand Down
Loading