Skip to content

Fix/fix bug of label layout #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuefei1313 merged 2 commits into from
Dec 2, 2025
Merged

Fix/fix bug of label layout #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
473fb38
fix: fix bug of label layout
xuefei1313 Dec 2, 2025
3ba72ec
docs: update changlog of rush
xuefei1313 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...on/changes/@visactor/vrender-components/fix-fix-bug-of-label-layout_2025-12-02-06-43.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: fix bug of label layout\n\n",
"type": "none",
"packageName": "@visactor/vrender-components"
}
],
"packageName": "@visactor/vrender-components",
"email": "lixuef1313@163.com"
}
11 changes: 11 additions & 0 deletions common/changes/@visactor/vrender-core/fix-fix-bug-of-label-layout_2025-12-02-06-43.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: fix bug of label layout\n\n",
"type": "none",
"packageName": "@visactor/vrender-core"
}
],
"packageName": "@visactor/vrender-core",
"email": "lixuef1313@163.com"
}
2 changes: 1 addition & 1 deletion packages/vrender-components/src/label/arc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export class ArcLabel extends LabelBase<ArcLabelAttrs> {

protected _layout(texts: (IText | IRichText)[]) {
if (!texts || !texts.length) {
return;
return [];
}

const labels = super._layout(texts);
Expand Down
2 changes: 1 addition & 1 deletion packages/vrender-components/src/label/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ export class LabelBase<T extends BaseLabelAttrs> extends AnimateComponent<T> {
for (let i = 0; i < texts.length; i++) {
const text = texts[i];
if (!text) {
return;
return [];
}
const textData = text.attribute as LabelItem;
const baseMark = this.getRelatedGraphic(textData);
Expand Down
Loading