Refactor NEOFLUX implementation for thread safety and race condition fix#9
Merged
VisualBoy merged 2 commits intoneoflux-implementationfrom Nov 29, 2025
Merged
Conversation
- Fixed DOM race condition by moving frontend initialization to `onAfterBinding`. - Added explicit DOM availability checks for `NeoFluxController`. - Implemented `threading.Lock` in `LedWorker` for thread-safe configuration updates. - Added G-code command deduplication to reduce serial traffic. - Removed redundant command key from API payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onAfterBinding.NeoFluxController.threading.LockinLedWorkerfor thread-safe configuration updates.Thank you for your interest into contributing to OctoPrint-LiveGCodeControl, it's highly appreciated!
Before submitting please make sure you have ticked all points on this checklist:
Feel free to delete all this help text, then describe your PR further. You may use the template provided below to do that. The more details the better!
What does this PR do and why is it necessary?
How was it tested? How can it be tested by the reviewer?
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes