Skip to content

fix(groupComparisonPlots): fix bug around printing#130

Merged
tonywu1999 merged 1 commit intodevelfrom
fix-plots
Apr 24, 2026
Merged

fix(groupComparisonPlots): fix bug around printing#130
tonywu1999 merged 1 commit intodevelfrom
fix-plots

Conversation

@tonywu1999
Copy link
Copy Markdown
Contributor

@tonywu1999 tonywu1999 commented Apr 24, 2026

Motivation and Context

Got an error w.r.t. renderPlotly: getting the error no applicable method for 'plotly_build' applied to an object of class "character". Viewport dimensions has zero

The error chain is:

  1. .plot.model.volcano calls print(pfinal) unconditionally (line 668 in utils_groupComparisonPlots.R) even when isPlotly = TRUE, which tries to render to the Shiny graphics device — causing "Viewport dimensions has zero"
  2. That error is caught by the tryCatch in create_group_comparison_plot, whose error handler returns the character notification ID from showNotification
  3. renderPlotly receives that character string → "no applicable method for 'plotly_build' applied to an object of class 'character'

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@tonywu1999 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 52 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 52 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca0a7b56-e5b7-48c7-956a-304bcaf9464d

📥 Commits

Reviewing files that changed from the base of the PR and between 885d4c1 and ce3c576.

📒 Files selected for processing (1)
  • R/utils_groupComparisonPlots.R
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-plots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tonywu1999 tonywu1999 merged commit db16d1a into devel Apr 24, 2026
3 checks passed
@tonywu1999 tonywu1999 deleted the fix-plots branch April 24, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant