You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ensure that the pvalueCutoff parameter is correctly passed to the getSubnetworkFromIndra function and behaves as expected. Validate that the pValue() function provides the correct value for this parameter.
Ensure that the pValue() function used in the getSubnetworkFromIndra call is properly defined and returns a valid numeric value, as undefined or invalid values could cause runtime errors.
Why: The suggestion addresses a potential runtime error by ensuring that pValue() returns a valid numeric value before being used as an argument in getSubnetworkFromIndra. This validation is crucial for preventing unexpected crashes and improving the robustness of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Need to ensure pvalueCutoff parameter is used when MSstatsShiny is calling MSstatsBioNet
PR Type
Bug fix, Enhancement
Description
Fixed how the
pvalueCutoffparameter is passed togetSubnetworkFromIndra.Added imports for
datatableandrenderDTfrom theDTpackage.Enhanced error handling in the
visualizeNetworkServerfunction.Changes walkthrough 📝
NAMESPACE
Added new imports for DT package functionsNAMESPACE
datatableandrenderDTfrom theDTpackage.module-visualize-network-server.R
Fixed pvalue filter and enhanced error handlingR/module-visualize-network-server.R
pvalueCutoffparameter usage ingetSubnetworkFromIndra.renderDTanddatatableto the function documentation.