Skip to content

Fix build#187

Merged
tonywu1999 merged 3 commits intodevelfrom
fix-build
Apr 20, 2026
Merged

Fix build#187
tonywu1999 merged 3 commits intodevelfrom
fix-build

Conversation

@tonywu1999
Copy link
Copy Markdown
Contributor

@tonywu1999 tonywu1999 commented Apr 20, 2026

Build is failing: https://bioconductor.org/checkResults/3.23/bioc-LATEST/MSstatsShiny/nebbiolo1-checksrc.html

This is due to the changes in MSstats that assumes heavy labels are references when applying equalizeMedians.

In the example dataset, it only had heavy peptides, and equalizeMedians was applied, which causes MSstats to crash. However, having only heavy peptides is an unrealistic scenario, especially for DIA.

Motivation and Context

The Bioconductor build was failing due to upstream changes in the MSstats package that treat heavy isotope labels as references when applying the equalizeMedians normalization function. The MSstatsShiny example DIA (Data Independent Acquisition) dataset contained only heavy peptides, which causes MSstats to crash when this function is applied. Since datasets containing only heavy peptides are unrealistic for DIA workflows, the solution was to modify the example dataset to include light peptides (standard unlabeled form) instead of exclusively heavy-labeled peptides. Additionally, the network visualization module was enhanced to support external API integration using the httr package.

Detailed Changes

  • Data modification: Updated data/example_dia_skyline.rda to use light isotope labels instead of heavy-only labels, resolving the incompatibility with MSstats' equalizeMedians function
  • Dependency management: Added httr to the package Imports in DESCRIPTION file to support HTTP requests
  • Namespace updates: Added imports to NAMESPACE for httr functions (POST, accept_json, content, content_type_json, status_code)
  • Module documentation: Updated roxygen documentation in R/module-visualize-network-server.R with @importFrom httr declarations for the five httr functions
  • Encoding fixes: Corrected UTF-8 encoding in help text of R/module-statmodel-server.R by replacing Unicode minus sign (−1) with ASCII hyphen (-1) in the comparison matrix UI description
  • Network visualization enhancement: Integrated httr API calls in the network visualization module to query the INDRA grounding service for protein name resolution via POST requests to https://grounding.indra.bio/ground

Unit Tests

Multiple test files are present in the test suite (e.g., tests/testthat/test-module-statmodel-server.R, tests/testthat/test_network_visualization.R), providing comprehensive coverage for module functionality. The test dataset in tests/testthat/data/dataset.csv contains entries with light isotope labels consistent with the example data modifications.

Coding Guidelines

All changes follow appropriate R/Shiny conventions including proper roxygen documentation for imports, correct module structure, and standard encoding declarations in DESCRIPTION.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

📝 Walkthrough

Walkthrough

The PR adds httr as a dependency to DESCRIPTION and NAMESPACE, imports related functions from httr and MSstatsBioNet for network visualization functionality, documents the httr imports in the visualizeNetworkServer module, and corrects a Unicode character to ASCII in UI help text.

Changes

Cohort / File(s) Summary
Package Manifest
DESCRIPTION, NAMESPACE
Added httr to package imports and declared new imports from httr (POST, content\_type\_json, accept\_json, content, status\_code) and MSstatsBioNet (deleteEdgeFromNetwork).
Module Documentation
R/module-visualize-network-server.R
Added roxygen @importFrom declaration documenting httr symbols used by the visualizeNetworkServer module.
UI Text Fix
R/module-statmodel-server.R
Updated comparison matrix help text by replacing Unicode minus sign (−1) with ASCII hyphen (-1).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

enhancement

Poem

🐰 A rabbit hops through package imports with glee,
httr arrives with functions to be,
Network edges deleted, requests made right,
Minor text tweaks bring characters in sight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix build' is vague and generic, providing no specific information about what aspect of the build is being fixed or what changes are made. Consider a more descriptive title like 'Fix build by updating example dataset labels and adding httr dependency' to clearly communicate the main changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tonywu1999 tonywu1999 merged commit 663fa12 into devel Apr 20, 2026
2 checks passed
@tonywu1999 tonywu1999 deleted the fix-build branch April 20, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant