fix(loadpage): wrap top 6 rows of preview table in horizontal scrollbar#196
fix(loadpage): wrap top 6 rows of preview table in horizontal scrollbar#196tonywu1999 merged 1 commit intodevelfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adjusts the UI rendering of three "Top 6 rows" preview tables by wrapping each Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation and Context
When displaying the top 6 rows of preview tables during data upload, tables that contain many columns can exceed the width of their container, causing horizontal overflow and poor user experience. This PR addresses the issue by enabling horizontal scrolling for these preview tables, allowing users to view all columns without horizontal page overflow affecting the page layout.
Changes
summary,summary_ptm,summary_prot) are now wrapped indivelements withstyle = "overflow-x: auto;"CSS appliedsummary)summary_ptm)summary_prot)summary_tablesreactive output in the loadpage server moduleUnit Tests
No unit tests were added or modified. The existing test suite in
tests/testthat/test-module-loadpage-ui.Rcovers UI structure validation but does not include specific tests for the server-side rendering of preview tables or their container styling.Coding Guidelines
The changes follow the project's established patterns and do not introduce any violations of the coding guidelines documented in
.github/CONTRIBUTING.md. The modification uses standard Shiny tag manipulation with CSS styling consistent with the codebase's approach to layout management.