Skip to content

fix(server-elysia): update tests to mock node:http instead of app.listen #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koushik-Salammagari wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −12
Open

fix(server-elysia): update tests to mock node:http instead of app.listen #1284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions packages/server-elysia/src/elysia-server-provider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,21 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import * as appFactory from "./app-factory";
import { ElysiaServerProvider } from "./elysia-server-provider";

// Mock dependencies
const mockHttpServer = {
listen: vi.fn((_port: number, _host: string, cb: () => void) => {
cb();
}),
close: vi.fn((cb: (err?: Error) => void) => {
cb();
}),
once: vi.fn(),
listening: true,
};

vi.mock("node:http", () => ({
createServer: vi.fn(() => mockHttpServer),
}));

vi.mock("@voltagent/server-core", async () => {
const actual = await vi.importActual("@voltagent/server-core");
return {
Expand All @@ -22,10 +36,10 @@ vi.mock("@voltagent/server-core", async () => {
describe("ElysiaServerProvider", () => {
let provider: ElysiaServerProvider;
const mockApp = {
listen: vi.fn().mockReturnValue({}),
stop: vi.fn(),
routes: [], // For extractCustomEndpoints
get: vi.fn(), // For configureApp test
fetch: vi.fn(),
routes: [],
get: vi.fn(),
};

const mockDeps = {
Expand Down Expand Up @@ -53,18 +67,18 @@ describe("ElysiaServerProvider", () => {
});

it("should start the server", async () => {
const { createServer } = await import("node:http");
await provider.start();
expect(appFactory.createApp).toHaveBeenCalled();
expect(mockApp.listen).toHaveBeenCalledWith({
port: 3000,
hostname: "0.0.0.0",
});
expect(createServer).toHaveBeenCalled();
expect(mockHttpServer.listen).toHaveBeenCalledWith(3000, "0.0.0.0", expect.any(Function));
});

it("should stop the server", async () => {
await provider.start();
await provider.stop();
expect(mockApp.stop).toHaveBeenCalled();
expect(mockHttpServer.close).toHaveBeenCalled();
});

it("should throw if already running", async () => {
Expand All @@ -82,10 +96,9 @@ describe("ElysiaServerProvider", () => {
it("should extract and display custom endpoints from configureApp", async () => {
const { printServerStartup } = await import("@voltagent/server-core");

// Create a fresh mock app for this test to avoid pollution
const localMockApp = {
listen: vi.fn().mockReturnValue({}),
stop: vi.fn(),
fetch: vi.fn(),
routes: [{ method: "GET", path: "/custom-test" }],
get: vi.fn(),
};
Expand All @@ -112,8 +125,7 @@ describe("ElysiaServerProvider", () => {
});

it("should handle startup errors and release port", async () => {
// Mock app.listen to throw
mockApp.listen.mockImplementationOnce(() => {
mockHttpServer.listen.mockImplementationOnce(() => {
throw new Error("Startup failed");
});

Expand Down