Skip to content

Everything except issue templates goes in repo root, template file moved.#1

Open
davidhesselbomvcc wants to merge 1 commit intoVolvoGroup:masterfrom
davidhesselbomvcc:move_pull-request-template
Open

Everything except issue templates goes in repo root, template file moved.#1
davidhesselbomvcc wants to merge 1 commit intoVolvoGroup:masterfrom
davidhesselbomvcc:move_pull-request-template

Conversation

@davidhesselbomvcc
Copy link
Copy Markdown

@davidhesselbomvcc davidhesselbomvcc commented Nov 22, 2019

See https://help.github.com/en/github/building-a-strong-community/creating-a-default-community-health-file-for-your-organization:

Issue templates and their configuration file must be in a folder called .github/ISSUE_TEMPLATE. All other supported files must be in the root of the repository.

I'm not absolutely positive about this, but this should mean that the pull request template also goes in the root.

I would really like to add issue templates to this repository as well, so that we don't have to keep them in sync across the other repositories (see https://github.com/VolvoGroup/Adapt/issues/378), but let's try getting the pull request template in the right place first.

@davidhesselbomvcc
Copy link
Copy Markdown
Author

Proof this PR is needed: https://github.com/VolvoGroup/app_ref has no docs or .github folder and no pull request template, so it should get its pull request template from this repo, but if you open a pull request in that repo, you get an empty text box, which you shouldn't, if this repo was set up correctly.

Curiously, the pull request template in this repo also didn't show when I opened this here pull request in this repo itself, so the pull request template isn't working even in its own repo! So something is clearly wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant