rnd 2867 metrics#62
Merged
Merged
Conversation
Collaborator
Christos-Hadjinikolis
left a comment
Christos-Hadjinikolis
left a comment
There was a problem hiding this comment.
Do existing tests pass?
joloppo
approved these changes
Aug 7, 2023
Contributor
joloppo
left a comment
joloppo
left a comment
There was a problem hiding this comment.
Nice work. Added a question about the test.
| _ = resource.read() | ||
| log_metric.assert_has_calls( | ||
| [ | ||
| call(column="foo_name", metric=Metric.COUNTS_PER_LABEL, value=8), |
Contributor
There was a problem hiding this comment.
Why are there two of these?
Contributor
Author
There was a problem hiding this comment.
One for each label that it finds
Contributor
Author
They pass, and I've added a new test just for metrics! |
arturk-vortexa
added
the
echoes/effort: M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing metrics logging through the Pandera API.
All of v4's metrics were migrated.
Migration scripts also implemented and tested locally.
All the user has to do is specify the desired metrics like this