Refactor v5#64
Merged
Merged
Conversation
matteo-pallini
suggested changes
Sep 11, 2023
matteo-pallini
left a comment
There was a problem hiding this comment.
Left a bunch of comments. Most of them are nitpicks, so feel free to ignore them. Probably there is just 3 that I think it's definitely worth addressing:
- removing commented out code and some
if __name__ == __main__switches in some modules - this comment https://github.com/VorTECHsa/dynamicio/pull/64/files#r1321512710
- this comment https://github.com/VorTECHsa/dynamicio/pull/64/files#r1321623019
Also, two other general comments:
- I don't understand most of what is going on in the hdf.py module. So, if you want me to review that too it may be worth having a quick chat, and then I will need to spend a bit of time on that
- Given that we spent quite a bit of time discussing about the refactoring design it may be worth also having someone else reviewing it. As, I am probably not in a good position to give you unbiased feedback on that
Contributor
Author
|
I've amended the PR - I left conversations I want you to have a look at open. Feel free to resolve them. |
matteo-pallini
approved these changes
Sep 18, 2023
matteo-pallini
left a comment
There was a problem hiding this comment.
It's a lot of changes, so maybe not everything will work perfectly on the first iteration but I think it's a step in the right direction. Thanks for doing this work, approved. As mentioned already, it may be worth having also another codeowner reviewing it, as it's a big change and I contributed to the design choices, so I am biased :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview