Skip to content

Conversation

@thomas771020
Copy link
Contributor

@john-hu please help me review this patch.Thank you.

@thomas771020 thomas771020 force-pushed the bug-98-use-preference-to-store-the-last-visit-card-position branch from 874ea33 to b13bd76 Compare August 30, 2014 02:35
@john-hu
Copy link
Member

john-hu commented Aug 30, 2014

Hi, you had broke a unit test: exec] org.vosie.wikicards.test.CardActivityTest:
[exec] Failure in testRemeberCardPosotion_get:
[exec] junit.framework.AssertionFailedError: expected:<1> but was:<0>
[exec] at org.vosie.wikicards.test.CardActivityTest.testRemeberCardPosotion_get(CardActivityTest.java:41)
[exec] at java.lang.reflect.Method.invokeNative(Native Method)
[exec] at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
[exec] at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
[exec] at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
[exec] at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
[exec] at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
[exec] at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
[exec] at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
[exec] .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without commit(), the preferences only saved in memory instead of storage. So, this patch may not work correctly. BTW, I think this issue's priority is not high. You may take your time to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants