Skip to content
This repository was archived by the owner on Dec 13, 2021. It is now read-only.

Conversation

@Niggelgame
Copy link

resolves #38

@Niggelgame Niggelgame requested a review from DRSchlaubi June 6, 2021 20:03
@DRSchlaubi
Copy link
Member

Run gradlew ktlintFormat to fix the CI

@Suppress("KDocMissingDocumentation", "unused", "MagicNumber")
object Colors {
// Discord
val BLURLPLE: Color = Color(114, 137, 218)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are actually wrong update them to match the new branding

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove all the non-existing colors?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or e.g. replace the current LIGHT_GREEN with the branding GREEN

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DRSchlaubi DRSchlaubi linked an issue Jun 6, 2021 that may be closed by this pull request
@DRSchlaubi
Copy link
Member

DRSchlaubi commented Jun 6, 2021

The base branch requires all commits to be signed. Learn more about signing commits.

DUDE

@Niggelgame
Copy link
Author

freak i used the wrong git profile

@DRSchlaubi
Copy link
Member

freak i used the wrong git profile

just rebase
squash
and sign that

@Niggelgame
Copy link
Author

actually forgot the squash

but fr took long enough for me to rebase on my own branch... until i found the IJ command to rebase on the root of the branch

@Niggelgame Niggelgame merged commit dfc9b29 into develop Jun 6, 2021
@Niggelgame Niggelgame deleted the feature/embeds branch June 6, 2021 20:45
@DRSchlaubi DRSchlaubi mentioned this pull request Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Update embeds

3 participants