Fixes to deletion of attachment and attachment content #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update existing tests to use the new method.
Azquelt
force-pushed
the
delete-attachment-content
branch
from
b0d3548 to
b778496
Compare
Add test that deleting asset deletes attachments Also add a check to ensure there are no attachments remaining in the database after clearing the repository at the end of each test. Note that previously, the code was trying to retrieve the attachments to delete by calling asset.getAttachments(). However, this doesn't work because the previous call to retrieveAssets() does not populate the asset object with its attachments. This is by design because we don't always want to return the attachments associated with an asset.
Make sure that attachment content is actually removed from the mongo database when the attachment is deleted. Add check to ensure attachment content is deleted Change Persistor.deleteAttachmentContent to take the gridFsId rather than the attachment id. This matches the signature for retrieveAttachmentMetadata and the difference is probably why the bug wasn't originally spotted. PersistenceBean.deleteAttachmentContent now actually does what it says it does. AssetServiceLayer change to match the new semantics of deleteAttachmentContent. RepositoryContext change to check for orphaned attachment content when cleaning repository between tests.
Azquelt
force-pushed
the
delete-attachment-content
branch
from
b778496 to
9a5ed96
Compare
idlewis
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes two problems
If assets are regularly added and removed from the repository, this leads to a build up of orphaned attachments and attachment content in the database which can only be removed manually.