Support building with java 8 #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es Deencapsulation.invoke and MockUp.getMockInstance so all uses of these methods needed rewriting
idlewis
reviewed
May 25, 2018
|
|
||
| private static AddThenHideOldStrategy _athos = new AddThenHideOldStrategy(); | ||
|
|
||
| private Object invoke(Object object, String methodName, Object... args) throws SecurityException, IllegalArgumentException, ClassNotFoundException, NoSuchMethodException, IllegalAccessException, InstantiationException, InvocationTargetException { |
Member
There was a problem hiding this comment.
Can we/should we use a common method in the ReflectionTricks class (test-utils project)?
Which would save writing this method multiple times
Member
Author
There was a problem hiding this comment.
Probably :)
In fact its quite similar to the existing reflectiveCall... methods in ReflectionTricks
Only problem is the method is actually slightly different in each class, but it should be doable - I will have a go.
idlewis
reviewed
Jun 5, 2018
LARS_versions.gradle
Outdated
| javax_json_version="1.0" | ||
| glassfish_json_version="1.0.+" | ||
| mongodb_java_version="2.13.0" | ||
| mongodb_java_version="2.14.+" |
Member
There was a problem hiding this comment.
Because the mongo jar version has to be specified exactly in the server.xml, and you have updated to 2.14.3, I think this needs to be exactly 2.14.3 as well. Even though that is a sucky thing to do
idlewis
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.