Add a front page to LARS displaying the server status #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new simple servlet which displays a welcome page with the number of assets in the server. This serves as a simple IVT and also allows monitoring tools to work in the default configuration where they attempt to retrieve the application root. Adding the new servlet required moving the root of the JAX-RS application from '/' to '/ma/v1' which resulted in some additional code changes. As a nice side-effect, I also made the BaseURL configuration a little more friendly so that it will work whether or not it ends with a slash. Updated the method names on Configuration to better clarify what they actually do. Changed AssetServiceLayer from `Singleton` to `ApplicationScoped`. Singleton is not a CDI scope, so presumably AssetServiceLayer was being injected as a dependant bean which is not what we want, especially if anyone actually tries to Serialize the FrontPageServlet.
idlewis
added a commit
that referenced
this pull request
Nov 4, 2015
Add a front page to LARS displaying the server status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new simple servlet which displays a welcome page with the number
of assets in the server. This serves as a simple IVT and also allows
monitoring tools to work in the default configuration where they attempt
to retrieve the application root.
Adding the new servlet required moving the root of the JAX-RS
application from '/' to '/ma/v1' which resulted in some additional code
changes.
As a nice side-effect, I also made the BaseURL configuration a little
more friendly so that it will work whether or not it ends with a slash.
Also changed AssetServiceLayer from
SingletontoApplicationScoped. Singleton is not a CDI scope, so presumably AssetServiceLayer was being injected as a dependant bean which is not what we want, especially if anyone actually tries to Serialize the FrontPageServlet.