[BUG] Empty filter sets should be ignored in getFilteredAssets #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of AbstractFileClient.getFilteredAssets will return an empty set (i.e. nothing will match) if any of the filter sets contain no values. This doesn't match the behaviour of the REST client. This fix will mean that empty filter sets are ignored, as per the REST client
idlewis
force-pushed
the
abstractFileClient_fix
branch
from
cd82398 to
7570c85
Compare
dbarfield
added a commit
that referenced
this pull request
Mar 3, 2016
[BUG] Empty filter sets should be ignored in getFilteredAssets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of AbstractFileClient.getFilteredAssets will
return an empty set (i.e. nothing will match) if any of the filter sets
contain no values. This doesn't match the behaviour of the REST client.
This fix will mean that empty filter sets are ignored, as per the REST
client