[BUG] Hidden assets should be published #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only published assets are hidden, so instead of making the hidden asset match the state of the previous asset, it is safe to explicitly make it published. This avoids an edge case where - a previous 'hide' has failed, leaving an unpublished matching asset - on retry, the AddThenDeleteStrategy matches the state of the new 'hidden' asset to the unpublished state of the failed 'hidden' asset, instead of matching the published state of the old, visible asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only published assets are hidden, so instead of making the hidden asset
match the state of the previous asset, it is safe to explicitly make it
published. This avoids an edge case where
'hidden' asset to the unpublished state of the failed 'hidden' asset,
instead of matching the published state of the old, visible asset