Qr codes by eswarchandravidyasagar · Pull Request #14 · WDGPH/immunization-charts-python

eswarchandravidyasagar · 2025-10-06T21:00:37Z

This pull request introduces QR code support for client immunization notices, updates both English and French templates to include a QR code column, and refactors data handling to support these changes. The most significant updates are grouped below by theme.

QR Code Generation and Data Integration

Added a generate_qr_code function to scripts/utils.py that creates a QR code PNG for each client and returns its file path. The function ensures output directories exist and uses client-specific filenames. [1] [2]
Modified the notice-building process in scripts/preprocess.py to generate and attach a QR code for each client, including relevant client data in the QR code. [1] [2] [3]

Template and Table Updates (English & French)

Updated both client_info_tbl_en and client_info_tbl_fr table functions in output/conf.typ to add a third column for the QR code, adjust column widths, and display the QR image if available. [1] [2]
Refactored the English and French template scripts to use the updated table functions and ensure the QR code appears in notices. This includes changes to how data is passed and displayed in the templates. [1] [2] [3] [4] [5] [6]

General Refactoring and Bug Fixes

Standardized variable names and improved the passing of client data and IDs throughout the scripts to support the new QR code logic and avoid mismatches. [1] [2]

These changes collectively enable QR code functionality in the generated immunization notices and ensure consistent formatting and data handling across both English and French versions.

- Added QR code generation utility function in utils.py - Modified preprocess.py to generate QR codes for each client - Updated French and English template scripts to include QR codes - Modified conf.typ to display QR codes in PDF notices - QR codes contain client ID, name, DOB, and school information - QR codes are saved as PNG files and embedded in PDFs

- Added QR code column to client_info_tbl_fr and client_info_tbl_en functions - QR codes are displayed in the top-right corner of immunization notices - Uses image.decode to render base64 encoded QR code images - Maintains responsive layout with proper column widths

Copilot

Pull Request Overview

This pull request introduces QR code functionality to client immunization notices, allowing QR codes containing client information to be embedded in both English and French notice templates.

Added QR code generation capability with client-specific data encoding
Updated English and French templates to include a new QR code column in client information tables
Refactored template functions to support the three-column layout with QR code display

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
scripts/utils.py	Added QR code generation function with PNG file output
scripts/preprocess.py	Integrated QR code generation into notice building process
scripts/2025_mock_generate_template_french.sh	Updated French template to include QR code column and fix parameter handling
scripts/2025_mock_generate_template_english.sh	Updated English template to include QR code column and fix syntax errors
output/conf.typ	Modified table functions to support three-column layout with QR code display

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T21:01:41Z

scripts/utils.py

+    else:
+        filename = "qr_code.png"
+
+    filepath = f"../qr_codes/{filename}"


The filepath variable points to '../qr_codes/' but the actual file is saved to '../output/qr_codes/'. This mismatch will cause issues when the QR code image is referenced.

Suggested change

filepath = f"../qr_codes/{filename}"

filepath = f"../output/qr_codes/{filename}"

Copilot · 2025-10-06T21:01:41Z

scripts/utils.py

+        filename = "qr_code.png"
+
+    filepath = f"../qr_codes/{filename}"
+    import os


Import statements should be placed at the top of the file with other imports, not inside functions.

Copilot · 2025-10-06T21:01:41Z

scripts/2025_mock_generate_template_english.sh

@@ -1,9 +1,51 @@
-#!/bin/bash
+#!/bi#let immunization_notice(data, value, immunizations_due, date, font_size) = block[


The shebang line is corrupted. It should be '#!/bin/bash' but contains embedded typst code.

Suggested change

#!/bi#let immunization_notice(data, value, immunizations_due, date, font_size) = block[

#!/bin/bash

Copilot · 2025-10-06T21:01:42Z

scripts/2025_mock_generate_template_english.sh

+    ]
+  ]],
+)
+]NDIR=${1}


The variable assignment is malformed. It should be 'INDIR=${1}' but has extra characters at the beginning.

Suggested change

]NDIR=${1}

INDIR=${1}

scripts/2025_mock_generate_template_english.sh

output/conf.typ

eswarchandravidyasagar · 2025-10-06T21:02:09Z

closes #3

kassyray · 2025-10-07T13:55:29Z

@eswarchandravidyasagar I think we may want the QR code in a different location for privacy purposes. The client information table provides information for the envelope (the way it is folded).

eswarchandravidyasagar · 2025-10-07T16:06:48Z

@eswarchandravidyasagar I think we may want the QR code in a different location for privacy purposes. The client information table provides information for the envelope (the way it is folded).

Feel free to commit that change based on what you think makes the most sense.

jangevaare · 2025-10-07T18:15:03Z

@eswarchandravidyasagar are there pros/cons of doing this via during data preparation rather than using a typst module?

jangevaare · 2025-10-07T18:18:41Z

@kassyray do you know if there is a performance hit to using vector graphics formats over compressed graphics formats in typst?

jangevaare · 2025-10-07T18:22:57Z

scripts/preprocess.py

+                "name": f"{row.FIRST_NAME} {row.LAST_NAME}",
+                "dob": row.DATE_OF_BIRTH,
+                "school": row.SCHOOL_NAME
+            }


It's likely that this data would vary by application - and is likely a URL with parameters

Wonder if we could potentially surface within an configuration in an f-string-like configuration, documenting and expanding available parameters in the readme. And validating the configuration as part of the generation pipeline?

It may be better within a separate function within the class, and then it can be an optional variable in this function and within the conf.typ function as well.

@jangevaare @eswarchandravidyasagar requested changes based on this as well as corruption to some variable names - please see comments under each change.

Moved Qr code generation to its own function and also improved configuration for QR codes and contact information

eswarchandravidyasagar · 2025-10-07T19:58:50Z

@eswarchandravidyasagar are there pros/cons of doing this via during data preparation rather than using a typst module?

I couldn't get the typst module to work for QR codes. Ran into some compatibility issues

scripts/utils.py

output/conf.typ

scripts/utils.py

…ality; update template columns for better layout in English and French versions.

eswarchandravidyasagar · 2025-10-14T13:54:20Z

closes #3

… layout

…d QR payload templates

…tact details

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

scripts/2025_mock_generate_template_french.sh

scripts/preprocess.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

eswarchandravidyasagar added 2 commits October 6, 2025 20:55

Copilot AI review requested due to automatic review settings October 6, 2025 21:00

Copilot AI reviewed Oct 6, 2025

View reviewed changes

eswarchandravidyasagar marked this pull request as draft October 7, 2025 13:24

eswarchandravidyasagar requested a review from kassyray October 7, 2025 16:07

jangevaare reviewed Oct 7, 2025

View reviewed changes

kassyray suggested changes Oct 7, 2025

View reviewed changes

scripts/utils.py Show resolved Hide resolved

output/conf.typ Outdated Show resolved Hide resolved

output/conf.typ Outdated Show resolved Hide resolved

eswarchandravidyasagar added 2 commits October 9, 2025 14:58

Update pyproject.toml dependencies and fix currupted english template

8cb00f6

Adjust spacing in immunization notice templates for improved readability

1c29339

jangevaare reviewed Oct 9, 2025

View reviewed changes

scripts/utils.py Outdated Show resolved Hide resolved

Refactor QR code generation to save as 1-bit PNG and improve image qu…

5082796

…ality; update template columns for better layout in English and French versions.

eswarchandravidyasagar marked this pull request as ready for review October 10, 2025 17:55

QR code support and improving layout

cbcc331

eswarchandravidyasagar added 6 commits October 15, 2025 13:01

Remove compiled Python bytecode file from the repository

33a6b3a

Remove French client info table and adjust English table for improved…

0c6dc5a

… layout

Add notice configuration support with customizable contact details an…

bcc9006

…d QR payload templates

Add notice configuration support with customizable QR payload and con…

ef934f2

…tact details

Focusing on Just QR code config for this PR

68d240d

Merge branch 'main' into qr-codes

eac1224

eswarchandravidyasagar requested review from Copilot, jangevaare and kassyray October 16, 2025 14:45

Copilot AI reviewed Oct 16, 2025

View reviewed changes

scripts/2025_mock_generate_template_french.sh Outdated Show resolved Hide resolved

scripts/preprocess.py Outdated Show resolved Hide resolved

scripts/preprocess.py Outdated Show resolved Hide resolved

eswarchandravidyasagar and others added 3 commits October 16, 2025 10:58

remove duplicated code

3def256

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix redundant code

7333596

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dob cleanup

4f67182

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jangevaare mentioned this pull request Oct 23, 2025

Refactor for single client PDF-based workflow #41

Closed

kassyray closed this Oct 27, 2025

kassyray deleted the qr-codes branch October 27, 2025 14:34

jangevaare mentioned this pull request Oct 29, 2025

Take 2: refactor for single client PDF-based workflow #59

Merged

	filepath = f"../qr_codes/{filename}"
	filepath = f"../output/qr_codes/{filename}"

		@@ -1,9 +1,51 @@
		#!/bin/bash
		#!/bi#let immunization_notice(data, value, immunizations_due, date, font_size) = block[

Comments

Conversation

eswarchandravidyasagar commented Oct 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eswarchandravidyasagar commented Oct 6, 2025

Uh oh!

kassyray commented Oct 7, 2025

Uh oh!

eswarchandravidyasagar commented Oct 7, 2025

Uh oh!

jangevaare commented Oct 7, 2025

Uh oh!

jangevaare commented Oct 7, 2025

Uh oh!

jangevaare Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

kassyray Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

kassyray Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

eswarchandravidyasagar Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

eswarchandravidyasagar commented Oct 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eswarchandravidyasagar commented Oct 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants