Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Reference implementation cleanup: allow setting the list of built-in modules #165

@domenic

Description

@domenic

This is a low-priority code cleanup that I want to just write down while it is fresh in my mind.

Until recently the reference implementation has had a list of built-in modules as a hard-coded list:

const supportedBuiltInModules = new Set([`${BUILT_IN_MODULE_SCHEME}:blank`]);

It only had std:blank, which we anticipate being specified as a built-in module that does nothing with no exports.

#164 added std:blank/for-testing in order to test some cases. That's not going to be specified anywhere. But it seemed important to get that coverage.

This architecture is inelegant. Instead, the reference implementation should take a list of built-in modules as an argument to resolve(), and the tests should inject a list appropriate for their testing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions