Fix #147: Require URLs to be absolute. #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effective request URIs probably already are, but RFC7230 doesn't say so explicitly.
Collaborator
|
Looks good to me, assuming the allowance of all schemes (incl |
Member
Author
|
I suspect we're going to need to restrict the schemes some, but I'm not sure to what (https only? potentially-trustworthy only?), so I was going to leave that open for now. |
Collaborator
|
lgtm |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 10, 2018
CertUrl and validityUrl and request URL must be absolute. WICG/webpackage#170 Currently the validity of certUrl and validityUrl is checked in ParseSignature(). But there is no validity check of the request url. And also there is no has_ref() check of all of them. So this CL adds these checks: - is_valid() and !has_ref() for request URL. - !has_ref() check for certUrl and validityUrl. Bug: 829932 Change-Id: I4502cb7cbb381e631292c8fd7a1ca998614f21b3 Reviewed-on: https://chromium-review.googlesource.com/1002338 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#549446}
twifkak
added a commit
to twifkak/amppackager
that referenced
this pull request
Apr 14, 2018
Add Cache-Control: no-transform to the signed-exchange response, to discourage intermediaries from modifying it. Add usqp to the fetch request, to tell the AMP Cache to perform web package transforms (in particular, additional headers). Add a note that URL fragments are disallowed, per WICG/webpackage#170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized this should probably also go in before I publish the implementation draft.
Spec: Preview, Diff
Impl draft: Preview, Diff