Vectorize phenology - example#113
Draft
fnattino wants to merge 6 commits into
Draft
Conversation
fnattino
commented
Apr 22, 2026
| DVS = self.kiosk["DVS"] | ||
|
|
||
| TEMP = _get_drv(drv.TEMP, self.params.shape, self.dtype, self.device) | ||
| TEMP = _get_drv(drv["TEMP"], self.params.shape, self.dtype, self.device) |
Collaborator
Author
There was a problem hiding this comment.
This should not be needed when using the TensorWeatherDataProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly explorative work on how to address #60 with an Xarray-based tensor weather data provider.
It builds on top of #112, which adds the basic functionality to keep running phenology simulations even though maturity is reached (feature needed in order to make parallel runs for different locations, since not all locations will reach maturity at the same time).
This PR includes the following changes, which are also in line with what needs to be addressed for #25:
TensorWeatherDataProviderclass, which allows to set up weather data providers from tensors, and takes care of the conversion from np.arrays to torch tensors.A notebook is also added to illustrate how the changes above, together with the current diffWOFOST infrastructure, allow to make parallel phenology runs (still, for the same crop). In a nutshell, the approach consists in setting a new fictitious time axis where all locations are aligned so that the date of sowing (DOS) happens on the same date. Also, quantities derived from the weather data (the daylength in the notebook) can be calculated as pre-processing of weather data rather than during model runs.