Finalizing the hybrid prototype#119
Conversation
SCiarella
left a comment
There was a problem hiding this comment.
Well done @SarahAlidoost 👍
The introduction of simulationobject.py and ovveride.py looks much cleaner.
I think we need to explain somewhere in the docs or even in the hybrid notebook how to use CROP_NN_MODEL because right now it would be hidden from the user.
Thanks for the suggestions.
Right! I won't add it to the same hybrid notebook because it makes it very busy. But I noticed that our doc is not updated regarding ml_models. I added it as a task to issue #107. |
SCiarella
left a comment
There was a problem hiding this comment.
@SarahAlidoost perfect! ready to merge
|



Closes #111
with this PR:
initofEngine, so the wofostinitializemethod does only the initialization of the components, as before.crop_componentsis done in init ofEngineCROP_NN_MODEL, this way an individual crop ml_model can be run using engine, see tests for details.