Skip to content

refactor: extract model creation method #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SarahAlidoost merged 1 commit into from
Sep 1, 2025
Merged

refactor: extract model creation method #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 13 additions & 25 deletions tests/physical_models/crop/test_leaf_dynamics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ def get_test_data(file_path):
return inputs["ModelResults"], inputs["Precision"]


def get_test_diff_leaf_model():
test_data_path = phy_data_folder / "test_leafdynamics_wofost72_01.yaml"
params, wdp, agro, external_states = prepare_engine_input(test_data_path)
config_path = str(phy_data_folder / "WOFOST_Leaf_Dynamics.conf")
return DiffLeafDynamics(params, wdp, agro, config_path, external_states)




class DiffLeafDynamics(torch.nn.Module):
def __init__(self, params, wdp, agro, config_path, external_states):
super().__init__()
Expand Down Expand Up @@ -132,13 +141,7 @@ def test_wofost_pp_with_leaf_dynamics(self):

class TestDiffLeafDynamicsTDWI:
def test_gradients_tdwi_lai_leaf_dynamics(self):
# prepare model input
test_data_path = phy_data_folder / "test_leafdynamics_wofost72_01.yaml"
params, wdp, agro, external_states = prepare_engine_input(test_data_path)
config_path = str(phy_data_folder / "WOFOST_Leaf_Dynamics.conf")

# create a model and optimizer
model = DiffLeafDynamics(params, wdp, agro, config_path, external_states)
model = get_test_diff_leaf_model()
tdwi = torch.nn.Parameter(torch.tensor(0.2, dtype=torch.float32))
output = model({"TDWI": tdwi})
lai = output[0, :, 0]
Expand All @@ -159,12 +162,7 @@ def test_gradients_tdwi_lai_leaf_dynamics(self):

def test_gradients_tdwi_twlv_leaf_dynamics(self):
# prepare model input
test_data_path = phy_data_folder / "test_leafdynamics_wofost72_01.yaml"
params, wdp, agro, external_states = prepare_engine_input(test_data_path)
config_path = str(phy_data_folder / "WOFOST_Leaf_Dynamics.conf")

# create a model and optimizer
model = DiffLeafDynamics(params, wdp, agro, config_path, external_states)
model = get_test_diff_leaf_model()
tdwi = torch.nn.Parameter(torch.tensor(0.2, dtype=torch.float32))
output = model({"TDWI": tdwi})
twlv = output[0, :, 1]
Expand All @@ -187,12 +185,7 @@ def test_gradients_tdwi_twlv_leaf_dynamics(self):
class TestDiffLeafDynamicsSPAN:
def test_gradients_span_lai_leaf_dynamics(self):
# prepare model input
test_data_path = phy_data_folder / "test_leafdynamics_wofost72_01.yaml"
params, wdp, agro, external_states = prepare_engine_input(test_data_path)
config_path = str(phy_data_folder / "WOFOST_Leaf_Dynamics.conf")

# create a model and optimizer
model = DiffLeafDynamics(params, wdp, agro, config_path, external_states)
model = get_test_diff_leaf_model()
span = torch.nn.Parameter(torch.tensor(30, dtype=torch.float32))
output = model({"SPAN": span})
lai = output[0, :, 0]
Expand All @@ -213,12 +206,7 @@ def test_gradients_span_lai_leaf_dynamics(self):

def test_gradients_span_twlv_leaf_dynamics(self):
# prepare model input
test_data_path = phy_data_folder / "test_leafdynamics_wofost72_01.yaml"
params, wdp, agro, external_states = prepare_engine_input(test_data_path)
config_path = str(phy_data_folder / "WOFOST_Leaf_Dynamics.conf")

# create a model and optimizer
model = DiffLeafDynamics(params, wdp, agro, config_path, external_states)
model = get_test_diff_leaf_model()
span = torch.nn.Parameter(torch.tensor(30, dtype=torch.float32))
output = model({"SPAN": span})
twlv = output[0, :, 1]
Expand Down