Skip to content

Add logo files to docs#31

Merged
SarahAlidoost merged 2 commits into
mainfrom
add_logo
Sep 29, 2025
Merged

Add logo files to docs#31
SarahAlidoost merged 2 commits into
mainfrom
add_logo

Conversation

@SarahAlidoost
Copy link
Copy Markdown
Collaborator

relates #10

@SarahAlidoost SarahAlidoost marked this pull request as ready for review September 18, 2025 13:23
Copy link
Copy Markdown
Collaborator

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why there is a pdf. The pdf seems to contain the rasterized logo again, so no vectors. What is the purpose of the pdf?
Including the odg file is nice. This is for later editing I think? My browser (and OS) don't know what to do with such a file though. So if your plan was to include a vector graphics file that can be used as an alternative to the png, I would suggest adding it a SVG instead.

Also, the logo is added to the repo, but it hasn't been added to any documents, such as the readme. Is that deliberately left for later?

@SarahAlidoost
Copy link
Copy Markdown
Collaborator Author

I'm not sure why there is a pdf. The pdf seems to contain the rasterized logo again, so no vectors. What is the purpose of the pdf? Including the odg file is nice. This is for later editing I think? My browser (and OS) don't know what to do with such a file though. So if your plan was to include a vector graphics file that can be used as an alternative to the png, I would suggest adding it a SVG instead.

Thanks. The pdf and original formats are replaced with svg.

Also, the logo is added to the repo, but it hasn't been added to any documents, such as the readme. Is that deliberately left for later?

yes, the logo can be used later.

@SarahAlidoost SarahAlidoost merged commit 82532ac into main Sep 29, 2025
8 of 10 checks passed
@SarahAlidoost SarahAlidoost deleted the add_logo branch September 29, 2025 07:56
@github-project-automation github-project-automation Bot moved this from In review to Done in DeltaCrop: epic1 and epic2 Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants