Use all test data

[SarahAlidoost]

closes #27

This PR:

• reads test data directly from its github repo, no need to download them
• uses all data in tests for checking the correctness of the model
• fixes a few bugs in leaf dynamics

[fnattino]

Hi @SarahAlidoost nice and clean! I have left one main comment related to some changes in leaf dynamics, I'd be interested to know what you think about that.

The current approach for testing is very nice, now we don't have to host the test data anymore as part of this repository. The drawback is that each test that requires external data fetches data from remote (actually the same dataset can also be fetched multiple times in a single test run). This will make tests slower (probably not a big deal) but also slightly less reliable (connections hiccups, timeouts).

We can simply try out how things work and reassess if we see that tests randomly fail because of remote access limitations. If this happen, an alternative approach could be to clone the PCSE repository before running tests and to set the path to the test data dir to be used in tests via some environment variable or config file. Much less elegant, but it would make sure data is fetched only once, and, if you run tests locally, you don't have to continuously download data from a remote.

[SarahAlidoost]

Hi @SarahAlidoost nice and clean! I have left one main comment related to some changes in leaf dynamics, I'd be interested to know what you think about that.

The current approach for testing is very nice, now we don't have to host the test data anymore as part of this repository. The drawback is that each test that requires external data fetches data from remote (actually the same dataset can also be fetched multiple times in a single test run). This will make tests slower (probably not a big deal) but also slightly less reliable (connections hiccups, timeouts).

We can simply try out how things work and reassess if we see that tests randomly fail because of remote access limitations. If this happen, an alternative approach could be to clone the PCSE repository before running tests and to set the path to the test data dir to be used in tests via some environment variable or config file. Much less elegant, but it would make sure data is fetched only once, and, if you run tests locally, you don't have to continuously download data from a remote.

you are right! thanks for pointing this out. A better approach is to ask pytest to download the test data for the test session. I added a conftest.py to do this, see my last commit. Since the test_data folder in pcse isnot a zip file, I had to specify the filenames. I think for now it is okay. Later, we can ask them to provide a zip file too.

[SarahAlidoost]

Hi @SarahAlidoost nice and clean! I have left one main comment related to some changes in leaf dynamics, I'd be interested to know what you think about that.

@fnattino thanks a lot for your comments and suggestions 🥇, I addressed them. Please let me know if something else should be fixed

[fnattino]

All looks good, thanks for the clarifications!

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud