Conversation
Vectorize leaf parameter Update leaf tests
|
In order to work with vectorized This PR also implements the function |
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella thanks for implementation and tests 👍 . Please have a look at my comments. The main issue with the current implementation is that the physical models shouldn’t be worry about the shape or format of their inputs. At this stage, we assume the physical model receives correctly shaped data, so it can do vectorized computations and proper gradient tracking. Everything else should be handled by the Engine. The physical model can include basic checks, but it shouldn’t go more than that.
If anything in my comments is unclear, please let me know, we can discuss the details.
Store shape outside of param class
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella looks great! thanks for addressing my comments. Just one test needed for weather data as 2d array, as we discussed :)
|



This PR addresses #45.
It follows the test structure of #55 to ensure that leaf parameters are differentiable and vectorizable.
Before merging, the issues with the vectorization of
drvshould be addressed.