Make 'assimilation' differentiable/vectorized#71
Merged
Conversation
Collaborator
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella I suggested a few changes so the tests can pass. If you agree, let's implement the suggestions. If something not clear, let me know.
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Collaborator
Author
|
@SarahAlidoost thanks for the suggestions! I have implemented all of them. I think that masking the average was the crucial point, causing the failure of the tests. |
| return {"PGASS": torch.stack([item["PGASS"] for item in results])} | ||
|
|
||
|
|
||
| def _afgen_y_mask(table_1d: torch.Tensor) -> torch.Tensor: |
Collaborator
There was a problem hiding this comment.
I think this function is better to be in utils.
SarahAlidoost
approved these changes
Jan 15, 2026
Collaborator
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella thanks for addressing comments. Just some minor changes for doctring and a test function that can be moved to utils. Then go ahead with merging 👍
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #42