Conversation
…k without further work
There was a problem hiding this comment.
Pull request overview
This PR updates the wheel build infrastructure to support Python 3.14 and addresses build compatibility issues. The changes modernize the build tooling by upgrading cibuildwheel to v3.3.0, exclude problematic PyPy wheels due to C-extension incompatibilities, and update the muparser dependency to version 2.3.5. The PR also includes minor code cleanup with trailing whitespace removal.
- Upgraded cibuildwheel from v2.21.3 to v3.3.0 to enable Python 3.14 wheel builds
- Added PyPy wheels to skip list to avoid C-extension build failures
- Updated muparser dependency from 2.3.4 to 2.3.5
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated skip configuration to exclude PyPy wheels in addition to musllinux, with improved comment documentation |
| conanfile.py | Bumped muparser dependency from 2.3.4 to 2.3.5 and removed trailing whitespace |
| .github/workflows/wheels.yml | Upgraded cibuildwheel action from v2.21.3 to v3.3.0, updated macOS runner comment, and cleaned up trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jorindevandevis
approved these changes
Dec 12, 2025
Contributor
jorindevandevis
left a comment
There was a problem hiding this comment.
Since it works, and copilot does not have comments, I am happy to approve this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now builds wheels for Python 3.14 too.
-MacOS-x86 still gets wrong arch somehow and fails so not including that.
https://github.com/Wall-Go/WallGoCollision/actions/runs/20160749787