-
Notifications
You must be signed in to change notification settings - Fork 0
Add @walletconnect/staking-cli package and CLI SDK improvements #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Copilot Autofix
AI 30 days ago
In general, to fix this kind of issue you should avoid constructing shell commands by concatenating untrusted strings and passing them to an API that invokes a shell (
exec/execSyncwith a single string). Instead, either (1) pass arguments as an array to a non-shell-spawning API such asexecFile/execFileSync, or (2) if you must invoke a shell, properly escape any untrusted values using a library likeshell-quotebefore embedding them in the command string.The best fix here, without changing functionality, is to keep calling the
castCLI but pass it as a program with separate arguments, so that the untrusteddatavalue is not interpreted by the shell. We can do this by importingexecFileSyncfromchild_processalongsideexecSync(leavingexecSyncuntouched if used elsewhere) and replacing the unsafeexecSync("cast 4d " + data, ...)call withexecFileSync("cast", ["4d", data], ...).execFileSyncdoes not invoke a shell and treatsdataas a literal argument tocast, eliminating command injection while preserving behavior (same program, same args, same options).Concretely:
packages/cli-sdk/src/client.tsto also importexecFileSync.logRequestDetails, replace theexecSyncinvocation on lines 234–238 with anexecFileSynccall that passes"cast"as the command and["4d", data]as the arguments, using the same options (encoding,timeout,stdio).No additional helper methods are needed; only this import and call-site replacement are required.