This repository was archived by the owner on Mar 21, 2023. It is now read-only.
Conversation
* Support remembering lure first seen, so that estimated lure duration can be more robust, and moved to front end. * Support scanning lure true expiration time when the stop is clicked.
TurtIeSocks
suggested changes
Oct 16, 2021
Collaborator
TurtIeSocks
left a comment
TurtIeSocks
left a comment
There was a problem hiding this comment.
As discussed on Discord, seeing some issues with lure_expire_timestamp being set to the current timestamp at scan time.
Contributor
Should be fixed now? Lmk |
Contributor
Author
|
Yes but @TurtIeSocks is unwilling to test it since he does not want to pull stop data from two different backends (for ReactMap). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New config options:
dataparser.lure.v2enables the new behavior anddataparser.lure.v2Webhookenables the new behavior for the webhook as well.Changes in behavior for v2:
lure_expiration_timenow storesNULLif the lure is active and has unknown expiration time, and0if there is not a lure when the stop is last scanned.