Merged
Conversation
TurtIeSocks
requested changes
Feb 18, 2022
Contributor
TurtIeSocks
left a comment
There was a problem hiding this comment.
Looks like you need add a default fallback value somewhere ( I can't remember where )
When I run npm run update/npm install the package-lock.json reverts to the old version, causing git issues. I'm stubborn and am still on npm v6, but I imagine most MapJS users at this point are still using an old npm version as well?
You can add an .npmrc file in the root of the project and set the contents to:
engine-strict=true
Then add this to the package.json:
"engines": {
"npm": ">=7.0.0"
},This way they'll get an error that at least instructs them what they need to do in order to run MapJS going forward (without causing git issues).
(base) ➜ mapFrontEnd git:(new-grunt-icons) ✗ npm install
npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for mapjs@1.10.0: wanted: {"npm":">=7.0.0"} (current: {"node":"16.13.2","npm":"6.14.16"})
npm ERR! notsup Not compatible with your version of node/npm: mapjs@1.10.0
npm ERR! notsup Not compatible with your version of node/npm: mapjs@1.10.0
npm ERR! notsup Required: {"npm":">=7.0.0"}
npm ERR! notsup Actual: {"npm":"6.14.16","node":"16.13.2"}
Collaborator
|
🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Lazy fix to latest team rocket invasions. We should totally just fallback to 0i.png. This will allow users to see icons and hide/show latest invasions for the upcoming Johto event.