Popup Templates Support

[versx]

Introduces the functionality to customize your own marker popup contents for the following:

• Pokemon
• Gyms (with Raids)
• Pokestops (with Lures/Quests/Invasions)
• Nests
• Spawnpoints (removed for performance issues)
• Weather
• Devices
• Scan Areas
• S2 Scan Cells (removed for performance issues)
• S2 Submission Cells (removed for performance issues)

TODO:

• Update docs to show all available options

[versx]

Please test 👀

[clburlison]

In it's current form this ejs template implementation is much much slower than master. I tested all of the templates with simple changes and they worked but filters like spawnpoints, submission cells, and s2 cells ended up taking the browser much longer to render when on this PR.

Additionally it locks the UI while it's attempting to render so it looks like it simply crashed. Waiting long enough does have the rendering complete.

Third point using /templates is not git friendly. I recommend putting the default templates some where inside of /src then have /templates/foobar.example.ejs files. Modify gitignore with

/templates/*
!/templates/*.example.ejs

When changes happen git won't prompt admin's to stash, commit, etc with local changes.

[Mygod]

Should probably look at #200 while you're at it.

[versx]

Should probably look at #200 while you're at it.

Should be fixed now, last thing is the raid popups still shift to the left. Normal gym icons are fine though.

[TurtIeSocks]

Still finishing up some work before more testing but some initial feedback:

• Scan Area is a bit sluggish, manageable, but maybe not necessary unless someone more creative than I can envision how these can be further customized?

• Pokemon also seem a bit sluggish, I don't remember them being this slow when I tested this previously.

• Pokemon image is stretched (Desktop, chrome)

• Quests & Invasions seem fine

• Pokemon in the raid popup also stretched, I think maybe we revert the recent commits? I'm not that worried about the ultra ball catch rate being on a separate line.

• Nests are also sluggish, I'm guessing this is related to the polygon drawing, similar to scan areas.

• Weather is sluggish

• I would suggest having a templates.example directory then have people copy the folder and rename to templates, instead of having to copy and rename each template file.

[Mygod]

Pokemon popup is not scaling the Pokemon correctly. Fix it.

[versx]

Pokemon popup is not scaling the Pokemon correctly. Fix it.

🤔 Seems fine to me?

[Mygod]

@versx Use an icon pack that is not square.

[versx]

@versx Use an icon pack that is not square.

Shuffle

Pogo

Home

[Mygod]

God damn it I bet it works fine on Koffing too.

[Mygod]

spot what is wrong with this pic

[versx]

spot what is wrong with this pic

I know the type icons are shifted to the left

[Mygod]

ok sPoT wHaT iS wRoNg

[TurtIeSocks]

Perhaps a more dramatic example >.>

[versx]

Ok that's more obvious! 😂

[Mygod]

Fix it or we are not merging your patch into our map.

[versx]

Fix it or we are not merging your patch into our map.

What if I can't? Will you help with your map? 😂

[Mygod]

Also are you fucking serious with these requests? This should explain all the slowness.

Fix it or we are not merging your patch into our map.

What if I can't? Will you help with your map? 😂

As a matter of fact, I will probably just delete your entire PR. If map admin wants to change a template, they can just edit js code.

[versx]

Also are you fucking serious with these requests? This should explain all the slowness.

Fix it or we are not merging your patch into our map.

What if I can't? Will you help with your map? 😂

As a matter of fact, I will probably just delete your entire PR. If map admin wants to change a template, they can just edit js code.