Skip to content

Exception Fixes, Name/Description Changes, and other Adjustments#4

Merged
WaterKH merged 11 commits intoWaterKH:mainfrom
KiernanBrown:main
Jul 6, 2024
Merged

Exception Fixes, Name/Description Changes, and other Adjustments#4
WaterKH merged 11 commits intoWaterKH:mainfrom
KiernanBrown:main

Conversation

@KiernanBrown
Copy link
Copy Markdown
Contributor

These changes were a joint effort between myself and SonicShadowSilver2 to try and clean up/clarify some things that were currently present and to work to fix some exceptions that were not functioning as intended.

  • Level Up Limit should account for all types now, as it was previously only taking the TypeA route levels into account.
  • When a check is adjusted during either the ProcessExceptions or ProcessLimiters sections of randomization, it is now added to a list and swaps to those checks are then disallowed for the remaining randomization. This was done since there would occasionally be issues with a check that had been set to a default from an exception being swapped to something else later in randomization, and certain exceptions were not working as intended as a result.
  • The Replace Golden Herc Rewards exception now replaces both the event for turning in all of the golden herc statues as well as the pick ups for each individual golden herc statue.
  • Added a list of problem chests that seemed to be having issues with properly rewarding abilities or VBonus rewards. These chests are now swapped for items during CleanUpOptions to avoid certain checks not being given properly.
  • Adjusted the list of important checks to remove stat boosts and stat boosting items. (SonicShadowSilver2)
  • Changed names/descriptions of chests/fights/locations to make things clearer when they are hinted or to better fit with how they are referred to in game. Removed special characters in certain character/location names when hinting since those were causing issues when being displayed in the game's information box. (SonicShadowSilver2)
  • Changed the name of Default Abilities and Early Critical Abilities exceptions to Default Base Abilities and Default Bonus Critical Abilities to make them clearer. (SonicShadowSilver2)
  • Changed descriptions for TypeA, TypeB, and TypeC level up routes. These were set to Warrior, Mystic, and Guardian before but it looks like they are tied to the Wisdom, Vitality, and Balance choices instead. (SonicShadowSilver2)
  • Changed the name of Battle Portals to Battlegates in order to fit with what they are referred to in game. (SonicShadowSilver2)
  • Adjusted the default randomization settings to have more consistently completable seeds. (SonicShadowSilver2)
    • Enemy/Boss/Party Members have been set to vanilla by default since they seemed to be a bit more unstable.
    • Battlegates are set to replace by default since not all of them would appear properly.

Added the changes Sonicshadowsilver2 made to the Extensions and HintService files. These changes adjust a few incorrect chests and some text for hints.
Turn off boss/enemy/party randomizer by default.
Adjusted Battle Portals to Battlegates to fit with the game's naming.
Added changes Sonicshadowsilver2 made to hint descriptions and default randomization settings.
First pass at addressing issues with Level Up Limit and Lucky Emblem Limit.
Merged Sonicshadowsilver2's changes to hint/chest descriptions.
Replace some problematic chests if they contain abilities or vbonus rewards
Added Monstropolis Chest 20 to the ProblemChests list
Updated Caribbean Chests
First pass at fixing the default abilities exceptions and the replace exceptions.
Merged Sonicshadowsilver2's changes for what is considered an important check. Merged Sonicshadowsilver2's changes for names and tooltips of a few exceptions.
Fixed some issues with the previous implementation of blocking checks when swapping.
@WaterKH WaterKH merged commit 1e06e57 into WaterKH:main Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants