Conversation
sam-watttime
approved these changes
Mar 14, 2025
Contributor
|
description from the original PR (which was merged into #42): This passes all tests and only reproduces the behavior that pd.json_normalize was performing, however that function has significantly more overhead. |
Closed
jcofield
force-pushed
the
faster-historical-forecast-parsing
branch
from
a1cfdee to
98b8bf3
Compare
jcofield
added a commit
that referenced
this pull request
Nov 2, 2025
jcofield
force-pushed
the
faster-historical-forecast-parsing
branch
from
98b8bf3 to
a8ed68e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the use of json.normalize within a for loop.
Why
It is 10x slower than direct assignment on each item in the json.
How
Use direct assignment within multiple for loops.
This change was successfully tested in #38. This change is also currently is passing tests on #42 which only has one other unrelated change.