Cp feature refactor #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Co-authored-by: Jenna Tomkinson <jenna.tomkinson@ucdenver.edu> * add files for CP run * remove run cellpose plugin * refactor idrstreams * create python merge files * remove unecessary create folder line * docs * change conda environments with bash file * black formatting
* rerun module * rerun script * rerun notebook * greg suggestion
* rerun format module * refactor raw data umaps * update utils * run umaps notebook * reconvert jupyter notebook * normalize training data * rerun pipeline * jenna suggestions
* rerun notebook * docs, convert notebook * Update 4.analyze_data/README.md Co-authored-by: Erik Serrano <31600622+axiomcura@users.noreply.github.com> * documentation --------- Co-authored-by: Erik Serrano <31600622+axiomcura@users.noreply.github.com>
gwaybio
approved these changes
Mar 9, 2023
Member
gwaybio
left a comment
gwaybio
left a comment
There was a problem hiding this comment.
Looks great! Three comments:
- I pointed out a possible typo
- I mentioned that you should consider setting constants outside of the for loop (to avoid setting the same thing over and over again)
- Please run
blackon all.pyfiles (except nbconverted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review!
All changes have already been reviewed in separate PRs.
As a reminder, this PR completes the refactor for mitocheck_data to include CP features in addition to the DP features that were already extracted and used. Merged (CP and DP) features are also analyzed in this repo after this PR.