Remove unused cp features #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MikeLippincott
approved these changes
May 2, 2023
Member
MikeLippincott
left a comment
MikeLippincott
left a comment
There was a problem hiding this comment.
One major comment: consider defining paths at top of file, unless I missed a dynamic assignment of the paths then please ignore. LGTM after you address comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review!
A quick PR to make sure that the only features compiled into the final labeled single-cell dataframe are those that we want to train with. These changes all take place in
utils/load_utils.py. Before this PR, some location features were included that did not help the final model accuracy (as they are related to the cell's specific location).This PR has about ~30 lines to review.