Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Jan 27, 2025

Description

This PR adds a Jupyter notebook-based demonstration of using nviz to ingest and then view some data. Along the journey here I also discovered there were some issues which needed to be worked out for usability so I resolved those here to make the notebook (and as a result, user-) experience more streamlined.

Thanks for any feedback!

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs marked this pull request as ready for review January 27, 2025 19:40
@d33bs d33bs requested a review from gwaybio January 27, 2025 19:41
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to make suggestions in the nbconverted file, but feel free to port over (without attributing me, if it's easier) to the jupyter notebook

Co-Authored-By: Gregory Way <gregory.way@gmail.com>
@d33bs
Copy link
Member Author

d33bs commented Jan 27, 2025

Thanks @gwaybio ! After making some changes to this based on your comments I'll now merge this in.

@d33bs d33bs merged commit 4dcf436 into WayScience:main Jan 27, 2025
3 checks passed
@d33bs d33bs deleted the notebook-demo branch January 27, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants